Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2404163002:
Add the new storage_unittests target to chromecast/BUILD.gn (Closed)
DescriptionAdd the new storage_unittests target to chromecast/BUILD.gn
storage_unittests will contain some of the tests that now (incorrectly)
live under content_unittests. Therefore, it should be built whenever
content_unittests is built.
BUG=653751
Committed: https://crrev.com/1e6964dbe48c79441a64423241e48ef59f64cb71
Cr-Commit-Position: refs/heads/master@{#424488}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add the new storage_unittests target to BUILD.gn files. storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 ========== to ========== Add the new storage_unittests target to chromecast/BUILD.gn storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
pwnall@chromium.org changed reviewers: + halliwell@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL?
halliwell@chromium.org changed reviewers: + mbjorge@chromium.org, slan@chromium.org
On 2016/10/11 03:29:08, pwnall wrote: > PTAL? lgtm, +slan and mbjorge in case anything additional is required internally.
https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn File chromecast/BUILD.gn (right): https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn#new... chromecast/BUILD.gn:148: "DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase", Not sure if any of these tests will be moved into storage_unittests from content_unittests, but if so, then please make a storage_unittests_filter and move the tests there.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thank you very much for the quick turnaround! https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn File chromecast/BUILD.gn (right): https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn#new... chromecast/BUILD.gn:148: "DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase", On 2016/10/11 03:55:06, mbjorge wrote: > Not sure if any of these tests will be moved into storage_unittests from > content_unittests, but if so, then please make a storage_unittests_filter and > move the tests there. Thank you for pointing this out! None of the tests that are currently in this list are slated to be moved.
On 2016/10/11 at 08:51:24, pwnall wrote: > Thank you very much for the quick turnaround! > > https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn > File chromecast/BUILD.gn (right): > > https://codereview.chromium.org/2404163002/diff/20001/chromecast/BUILD.gn#new... > chromecast/BUILD.gn:148: "DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase", > On 2016/10/11 03:55:06, mbjorge wrote: > > Not sure if any of these tests will be moved into storage_unittests from > > content_unittests, but if so, then please make a storage_unittests_filter and > > move the tests there. > > Thank you for pointing this out! > > None of the tests that are currently in this list are slated to be moved. kk, then lgtm
lgtm!
The CQ bit was checked by pwnall@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add the new storage_unittests target to chromecast/BUILD.gn storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 ========== to ========== Add the new storage_unittests target to chromecast/BUILD.gn storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add the new storage_unittests target to chromecast/BUILD.gn storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 ========== to ========== Add the new storage_unittests target to chromecast/BUILD.gn storage_unittests will contain some of the tests that now (incorrectly) live under content_unittests. Therefore, it should be built whenever content_unittests is built. BUG=653751 Committed: https://crrev.com/1e6964dbe48c79441a64423241e48ef59f64cb71 Cr-Commit-Position: refs/heads/master@{#424488} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1e6964dbe48c79441a64423241e48ef59f64cb71 Cr-Commit-Position: refs/heads/master@{#424488} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
