Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 240413004: Move instrumented-libraries-related settings out of common.gypi. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move instrumented-libraries-related settings out of common.gypi. Instead, apply them as direct_dependent_settings to dependents of the instrumented_libraries target. This is functionally equivalent, but reduces code duplication, improves locality and also allows us to disable the use of instrumented libraries on a target-by-target basis. BUG=313751 TBR=glider@chromium.org TEST=MSan NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
earthdok
PTAL When I switch between this and ToT, nothing is rebuilt, so looks like zero ...
6 years, 8 months ago (2014-04-16 18:19:35 UTC) #1
earthdok
committing with NOTRY
6 years, 8 months ago (2014-04-16 19:19:50 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 8 months ago (2014-04-16 19:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/240413004/1
6 years, 8 months ago (2014-04-16 19:22:15 UTC) #4
commit-bot: I haz the power
Change committed as 264281
6 years, 8 months ago (2014-04-16 19:23:28 UTC) #5
Nico
On 2014/04/16 18:19:35, earthdok wrote: > PTAL > > When I switch between this and ...
6 years, 8 months ago (2014-04-16 19:30:06 UTC) #6
earthdok
6 years, 8 months ago (2014-04-16 19:34:55 UTC) #7
Message was sent while issue was closed.
On 2014/04/16 19:30:06, Nico wrote:
> (I sometimes create ninja files with and without my change into different
output
> directories using -Goutput_dir, and then compare the generated ninja files for
> checks like this.)

Thanks for the tip!

Powered by Google App Engine
This is Rietveld 408576698