Geolocation: move polling policy to its own file.

Geolocation: move polling policy to its own file.

This change permits cleaning up the dependencies in WifiDataProviderChromeOs, it was pulling in WifiDataProviderCommon not to derive it, but to use the polling policy. It doesn't actually use WifiDataProviderCommon::WlanApiInterface.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222069

[Michael van Ouwerkerk, 2013-09-06 15:48:42]

Hi Marcus, another minor piece of cleanup. This was confusing how the
geolocation code interrelates.

[bulach, 2013-09-06 16:01:38]

lgtm thanks! just some nits below:

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
File content/browser/geolocation/wifi_polling_policy.h (right):

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:11: class
PollingPolicyInterface {
nit: jam@ complained that some of the device orientation components had too
generic names, since they weren't in a namespace anymore..

so maybe just "WifiPollingPolicy" would be clearer (and match the file name as
well..)

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:18: virtual int
NoWifiInterval() = 0;
nit: I think it needs a private: DISALLOW_COPY_AND_ASSIGN(..);

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:27: class GenericPollingPolicy
: public PollingPolicyInterface {
then this can become GenericWifiPollingPolicy?

[Michael van Ouwerkerk, 2013-09-06 19:05:01]

Thanks for the quick review!

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
File content/browser/geolocation/wifi_polling_policy.h (right):

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:11: class
PollingPolicyInterface {
On 2013/09/06 16:01:38, bulach wrote:
> nit: jam@ complained that some of the device orientation components had too
> generic names, since they weren't in a namespace anymore..
> 
> so maybe just "WifiPollingPolicy" would be clearer (and match the file name as
> well..)

Done.

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:18: virtual int
NoWifiInterval() = 0;
On 2013/09/06 16:01:38, bulach wrote:
> nit: I think it needs a private: DISALLOW_COPY_AND_ASSIGN(..);

Done.

https://codereview.chromium.org/24041003/diff/1/content/browser/geolocation/w...
content/browser/geolocation/wifi_polling_policy.h:27: class GenericPollingPolicy
: public PollingPolicyInterface {
On 2013/09/06 16:01:38, bulach wrote:
> then this can become GenericWifiPollingPolicy?

Done.

[commit-bot: I haz the power, 2013-09-09 12:40:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/24041003/7001

[commit-bot: I haz the power, 2013-09-09 12:52:06]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-09-09 12:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/24041003/7001

[jam, 2013-09-09 15:02:10]

gypi lgtm

[commit-bot: I haz the power, 2013-09-09 15:26:05]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-09-09 19:05:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/24041003/7001

[commit-bot: I haz the power, 2013-09-09 19:07:52]

Change committed as 222069