Issue 24041002: Turn off future-timestamp cloud policy checks on desktop

Issue 24041002: Turn off future-timestamp cloud policy checks on desktop (Closed)

Created:
7 years, 3 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 3 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn off future-timestamp cloud policy checks on desktop BUG=279099 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222028

Patch Set 4 : Changed enum name to TIMESTAMP_NOT_BEFORE #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -17 lines)			Patch
M	chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/cloud/cloud_policy_validator.h	View	1 2 3	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/cloud/cloud_policy_validator.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/cloud_policy_validator_unittest.cc	View	1 2 3	5 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/cloud/user_cloud_policy_store.cc	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud/user_cloud_policy_store_base.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/user_cloud_policy_store_base.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

On 2013/09/06 16:31:47, Andrew T Wilson wrote: > PTAL BTW, I decided to leave *some* ...

7 years, 3 months ago (2013-09-07 11:54:59 UTC) #2

Mattias Nissler (ping if slow)

LGTM w/ nit. https://codereview.chromium.org/24041002/diff/3001/chrome/browser/policy/cloud/cloud_policy_validator.h File chrome/browser/policy/cloud/cloud_policy_validator.h (right): https://codereview.chromium.org/24041002/diff/3001/chrome/browser/policy/cloud/cloud_policy_validator.h#newcode88 chrome/browser/policy/cloud/cloud_policy_validator.h:88: TIMESTAMP_REQUIRED_BUT_SYSTEM_TIME_UNRELIABLE, Naming here is a bit ...

7 years, 3 months ago (2013-09-09 08:00:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/24041002/21001

7 years, 3 months ago (2013-09-09 12:10:35 UTC) #4

Message was sent while issue was closed.

Change committed as 222028

Expand Messages | Collapse Messages