Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2404073002: Re-enable fast/html/details* tests on Mac Retina. (Closed)

Created:
4 years, 2 months ago by wkorman
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable fast/html/details* tests. Passes Mac10.11 Retina trybot. Running tests locally with these baselines removed on a Mac Retina laptop passes. Running one test 100 times shows 100% pass rate. BUG=637245 TBR=pdr Committed: https://crrev.com/85149a47ba2c6e35561cb662a2cdc728f2e906cf Cr-Commit-Position: refs/heads/master@{#424636}

Patch Set 1 #

Patch Set 2 : Remove obsolete baselines. #

Patch Set 3 : Merge branch 'master' into 637245_reenable_retina_media_tests #

Patch Set 4 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -191 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-1-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-1-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-10-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-10-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-2-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-2-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-3-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-3-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-4-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-4-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-5-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-5-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-6-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-6-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-7-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-7-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-8-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-8-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-9-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-9-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-1-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-1-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-2-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-2-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-3-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-3-and-click-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-4-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-4-and-click-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-5-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-5-and-click-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-6-and-click-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-6-and-click-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404073002/20001
4 years, 2 months ago (2016-10-11 23:47:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/278841)
4 years, 2 months ago (2016-10-11 23:58:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404073002/40001
4 years, 2 months ago (2016-10-12 00:06:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/143734) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 2 months ago (2016-10-12 00:10:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404073002/60001
4 years, 2 months ago (2016-10-12 00:16:05 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-12 01:30:24 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:32:40 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/85149a47ba2c6e35561cb662a2cdc728f2e906cf
Cr-Commit-Position: refs/heads/master@{#424636}

Powered by Google App Engine
This is Rietveld 408576698