Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4014)

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 2404013002: [Extensions] Remove ChromeSyncExtensionFunction (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_extension_function.h
diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h
index d16b95663980365956ee3639d8c86f84d4bc92cc..b325f5509705cd12f6cd2baec2a8d3d3d2a5f76c 100644
--- a/chrome/browser/extensions/chrome_extension_function.h
+++ b/chrome/browser/extensions/chrome_extension_function.h
@@ -112,31 +112,4 @@ class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
ResponseAction Run() final;
};
-// A chrome specific analog to SyncExtensionFunction. This has access to a
-// chrome Profile.
-//
-// DEPRECATED: Please consider inherting UIThreadExtensionFunction or
-// SyncExtensionFunction directly. Then if you need access to Chrome details,
-// you can construct a ChromeExtensionFunctionDetails object within your
-// function implementation.
-class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
- public:
- ChromeSyncExtensionFunction();
-
- protected:
- ~ChromeSyncExtensionFunction() override;
-
- // Deprecated, see SyncExtensionFunction::RunSync.
- virtual bool RunSync() = 0;
-
- // ValidationFailure override to match RunSync().
- static bool ValidationFailure(ChromeSyncExtensionFunction* function);
-
- private:
- // If you're hitting a compile error here due to "final" - great! You're doing
- // the right thing, you just need to extend ChromeUIThreadExtensionFunction
- // instead of ChromeSyncExtensionFunction.
- ResponseAction Run() final;
-};
-
#endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698