Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2403973002: use IsHLSURL() instead of IsHLSPath() (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use IsHLSURL() instead of IsHLSPath() according to UMA, the former is much better in detecting HLS streams BUG=605691 Committed: https://crrev.com/0d95212797289eebff36fec22033fa8859c7904b Cr-Commit-Position: refs/heads/master@{#424231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
qinmin
PTAL
4 years, 2 months ago (2016-10-10 19:23:16 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 2 months ago (2016-10-10 19:26:41 UTC) #3
sandersd (OOO until July 31)
On 2016/10/10 19:26:41, sandersd wrote: > lgtm Note though that this UMA is not trustowrthy, ...
4 years, 2 months ago (2016-10-10 19:27:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403973002/1
4 years, 2 months ago (2016-10-10 19:29:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 20:43:51 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 20:46:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d95212797289eebff36fec22033fa8859c7904b
Cr-Commit-Position: refs/heads/master@{#424231}

Powered by Google App Engine
This is Rietveld 408576698