Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2403953003:
Add a watch for vakh for components/safe_browsing_db code (Closed)
|
Created:
4 years, 2 months ago by vakh (use Gerrit instead) Modified:
4 years, 2 months ago CC:
chromium-reviews, Nathan Parker Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a watch for vakh for components/safe_browsing_db code
Test:
$ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc
['vakh+watch@chromium.org']
History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_browsing_db
TBR=agrieve, ben
Committed: https://crrev.com/f8e14c9c22f9429c680f90984fb8935f45565339
Cr-Commit-Position: refs/heads/master@{#425780}
Patch Set 1 #
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a watch for vakh for components/safe_browsing_db code BUG= ========== to ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] ==========
vakh@chromium.org changed reviewers: + ben@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] ========== to ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... ==========
vakh@chromium.org changed reviewers: + agrieve@chromium.org
Description was changed from ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... ========== to ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... TBR=agrieve, ben ==========
The CQ bit was checked by vakh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... TBR=agrieve, ben ========== to ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... TBR=agrieve, ben ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... TBR=agrieve, ben ========== to ========== Add a watch for vakh for components/safe_browsing_db code Test: $ /usr/local/google/home/vakh/work/chrome/depot_tools/watchlists.py components/safe_browsing_db/v4_database.cc ['vakh+watch@chromium.org'] History of commits to that directory: https://chromium.googlesource.com/chromium/src/+log/master/components/safe_br... TBR=agrieve, ben Committed: https://crrev.com/f8e14c9c22f9429c680f90984fb8935f45565339 Cr-Commit-Position: refs/heads/master@{#425780} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f8e14c9c22f9429c680f90984fb8935f45565339 Cr-Commit-Position: refs/heads/master@{#425780} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
