Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2403953002: Merge to M54: Android accessibility actions inside iframes not sent to right frame (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge to M54: Android accessibility actions inside iframes not sent to right frame When sending a message from the BrowserAccessibilityManagerAndroid to the render process to perform some accessibility action on a node, we need to send it to the right frame by calling the delegate function on the node's BrowserAccessibilityManager. We were incorrectly calling it on the current BrowserAccessibilityManager, which is only the same for elements in the root frame. BUG=562757 Review-Url: https://codereview.chromium.org/2395533002 Cr-Commit-Position: refs/heads/master@{#422887} (cherry picked from commit 909ee6ee26be0ad7f89e07806c96f142328e0993) Committed: https://chromium.googlesource.com/chromium/src/+/852c2f7299bca42d9885b5f2cefab577b2d76964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 7 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 2 months ago (2016-10-10 18:44:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
852c2f7299bca42d9885b5f2cefab577b2d76964.

Powered by Google App Engine
This is Rietveld 408576698