Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2403923003:
[Chromoting] Reenable 64-bit build checks for Windows (Closed)
Description[Chromoting] Reenable 64-bit build checks for Windows
After discussing with team members, we prefer to keep generating 64 bit host archive.
BUG=623077
TBR=mmoss@chromium.org
Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59
Cr-Commit-Position: refs/heads/master@{#424314}
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Chromoting] Reenable 64-bit build checks for Windows BUG=623077 ========== to ========== [Chromoting] Reenable 64-bit build checks for Windows BUG=623077 ==========
zijiehe@chromium.org changed reviewers: + joedow@chromium.org
lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== [Chromoting] Reenable 64-bit build checks for Windows BUG=623077 ========== to ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 ==========
zijiehe@chromium.org changed reviewers: + mmoss@chromium.org
Description was changed from ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 ========== to ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 TBR=mmoss@chromium.org ==========
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 TBR=mmoss@chromium.org ========== to ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 TBR=mmoss@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 TBR=mmoss@chromium.org ========== to ========== [Chromoting] Reenable 64-bit build checks for Windows After discussing with team members, we prefer to keep generating 64 bit host archive. BUG=623077 TBR=mmoss@chromium.org Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 Cr-Commit-Position: refs/heads/master@{#424314} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 Cr-Commit-Position: refs/heads/master@{#424314}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2405253003/ by alph@chromium.org. The reason for reverting is: Speculative revert for possibly causing a failure of official build. See crbug.com/654818. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
