Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8701)

Unified Diff: components/safe_browsing_db/v4_store.h

Issue 2403913004: Small: Serialize the store's hash_prefix_map_ to file in WriteToDisk() (Closed)
Patch Set: Serialize the store's hash_prefix_map_ to file in WriteToDisk() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | components/safe_browsing_db/v4_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_store.h
diff --git a/components/safe_browsing_db/v4_store.h b/components/safe_browsing_db/v4_store.h
index a2a89be440fbc1d185afb96838179dc31fdb80c6..3d7626257667963ab2d292d55cc75e8121678255 100644
--- a/components/safe_browsing_db/v4_store.h
+++ b/components/safe_browsing_db/v4_store.h
@@ -352,8 +352,11 @@ class V4Store {
HashPrefixMap* additions_map);
// Writes the FULL_UPDATE |response| to disk as a V4StoreFileFormat proto.
Nathan Parker 2016/10/11 20:29:42 There's no longer a |response| arg
vakh (use Gerrit instead) 2016/10/11 21:50:39 Done.
- StoreWriteResult WriteToDisk(
- std::unique_ptr<ListUpdateResponse> response) const;
+ // |list_id| is used to set the (|platform_type|, |threat_entry_type|,
+ // threat_type|) fields, and |checksum| is used to set the |checksum| field in
+ // the final proto.
+ StoreWriteResult WriteToDisk(const ListIdentifier& list_id,
+ const Checksum& checksum) const;
// The checksum value as read from the disk, until it is verified. Once
// verified, it is cleared.
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | components/safe_browsing_db/v4_store.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698