Pepper API implementation for output protection.

chromeos/display/output_configurator.cc

Index: chromeos/display/output_configurator.cc
diff --git a/chromeos/display/output_configurator.cc b/chromeos/display/output_configurator.cc
index 78cb31869d4bca60403cbc4c4909b547e95d431a..a356e2643995aaf02adedbde0e5d40f5b5bace72 100644
--- a/chromeos/display/output_configurator.cc
+++ b/chromeos/display/output_configurator.cc
@@ -234,6 +234,32 @@ void OutputConfigurator::Start(uint32 background_color_argb) {
   NotifyObservers(success, new_state);
 }
 
+bool OutputConfigurator::QueryOutputProtectionStatus(
+    chrome::PepperOutputProtectionHost* client,
+    uint32_t* link_mask,
+    uint32_t* protection_mask) {
+  if (!configure_display_)
+    return false;
+
+  delegate_->GrabServer();
+  bool result = delegate_->QueryOutputProtectionStatus(client, link_mask,
+                                                       protection_mask);
+  delegate_->UngrabServer();

[dmichael (off chromium), 2013/09/09 20:37:15]

I don't know anything about that delegate or what GrabServer/UngrabServer does,
but it would be nice if that delegate defined a scoped sentinel to make sure
UngrabServer is called when exiting scope. To prevent mistakes if functions can
return early.

I.e. something you could use like this:
{
  ScopedServerGrabber grab_server(delegate_);
  // Do something with delegate_
} // UngrabServer gets called automatically.

[kcwu, 2013/09/10 12:50:21]

Agree. However there are 4 existing GrabServer() in this file works this way. Do
you suggest me refactor them or just follow them?

[dmichael (off chromium), 2013/09/11 18:22:45]

Following them is fine. But it's worth considering a follow-up CL.

[kcwu, 2013/09/12 18:22:08]

Thanks

+  return result;
+}
+
+bool OutputConfigurator::EnableOutputProtection(
+    chrome::PepperOutputProtectionHost* client,
+    uint32_t desired_method_mask) {
+  if (!configure_display_)
+    return false;
+
+  delegate_->GrabServer();
+  bool result = delegate_->EnableOutputProtection(client, desired_method_mask);
+  delegate_->UngrabServer();
+  return result;
+}
+
 void OutputConfigurator::Stop() {
   configure_display_ = false;
 }