chromeos/display/DEPS - Issue 24039002: Pepper API implementation for output protection.

Side by Side Diff: chromeos/display/DEPS

Issue 24039002: Pepper API implementation for output protection. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revise output configurator related code. rebased. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-chromeos",	2 "+ui/base/x",
	Daniel Erat 2013/09/20 15:00:24 per elliot's https://codereview.chromium.org/23536 per elliot's https://codereview.chromium.org/23536057/, chromeos probably shouldn't depend on ui/. i'll let him weigh in on this, but perhaps the error handler should be moved under base/, as he's doing with other ui stuff in his CL. Elliot Glaysher 2013/09/20 16:28:20 It's a combination of dependency aesthetics (chrom Show quoted text On 2013/09/20 15:00:24, Daniel Erat wrote: > per elliot's https://codereview.chromium.org/23536057/, chromeos probably > shouldn't depend on ui/. i'll let him weigh in on this, but perhaps the error > handler should be moved under base/, as he's doing with other ui stuff in his > CL. It's a combination of dependency aesthetics (chromeos/ shouldn't depend on ui/ because they do very different things) and the problem that this won't link in some configurations. I'd REALLY prefer if chromeos/ didn't depend on ui/, but if you do go that route, make sure that it depends on ui, via gyp. kcwu 2013/09/20 17:55:13 It's nice that these common things moved to base/. Show quoted text On 2013/09/20 16:28:20, Elliot Glaysher wrote: > On 2013/09/20 15:00:24, Daniel Erat wrote: > > per elliot's https://codereview.chromium.org/23536057/, chromeos probably > > shouldn't depend on ui/. i'll let him weigh in on this, but perhaps the error > > handler should be moved under base/, as he's doing with other ui stuff in his > > CL. > > It's a combination of dependency aesthetics (chromeos/ shouldn't depend on ui/ > because they do very different things) and the problem that this won't link in > some configurations. I'd REALLY prefer if chromeos/ didn't depend on ui/, but if > you do go that route, make sure that it depends on ui, via gyp. It's nice that these common things moved to base/. Let me move ui/base/x/x11_error_tracker.* to base/x11, how do you feel? Elliot Glaysher 2013/09/20 22:54:10 I'm fine with that. (However, there currently isn' Show quoted text On 2013/09/20 17:55:13, kcwu wrote: > On 2013/09/20 16:28:20, Elliot Glaysher wrote: > > On 2013/09/20 15:00:24, Daniel Erat wrote: > > > per elliot's https://codereview.chromium.org/23536057/, chromeos probably > > > shouldn't depend on ui/. i'll let him weigh in on this, but perhaps the > error > > > handler should be moved under base/, as he's doing with other ui stuff in > his > > > CL. > > > > It's a combination of dependency aesthetics (chromeos/ shouldn't depend on ui/ > > because they do very different things) and the problem that this won't link in > > some configurations. I'd REALLY prefer if chromeos/ didn't depend on ui/, but > if > > you do go that route, make sure that it depends on ui, via gyp. > > It's nice that these common things moved to base/. Let me move > ui/base/x/x11_error_tracker.* to base/x11, how do you feel? I'm fine with that. (However, there currently isn't a base/x11/ directory; the first patch that adds files is currently under review. That said, since you aren't adding the same code, I don't see a reason to block on me.)
3 ]	3 ]

OLD	NEW

« no previous file with comments | « chrome/test/ppapi/ppapi_browsertest.cc ('k') | chromeos/display/output_configurator.h » ('j') | chromeos/display/output_configurator.h » ('J')