content/shell/renderer/layout_test/blink_test_runner.h - Issue 2403893002: Add layout test for reply property of notificationclick event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.h

Issue 2403893002: Add layout test for reply property of notificationclick event (Closed)

Patch Set: Make reply field nullable in .idl files; add test cases for empty and null Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/layout_test/blink_test_runner.h

diff --git a/content/shell/renderer/layout_test/blink_test_runner.h b/content/shell/renderer/layout_test/blink_test_runner.h

index 0ef7a287fdf54fce42421a63b27e692f483fb15e..cbdab005b475c58a4845373b195243dfbb1c0f4b 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.h

+++ b/content/shell/renderer/layout_test/blink_test_runner.h

@@ -98,8 +98,10 @@ class BlinkTestRunner : public RenderViewObserver,

std::string EvaluateInWebInspectorOverlay(const std::string& script) override;

void ClearAllDatabases() override;

void SetDatabaseQuota(int quota) override;

- void SimulateWebNotificationClick(const std::string& title,

- int action_index) override;

+ void SimulateWebNotificationClick(

+ const std::string& title,

+ int action_index,

+ const base::NullableString16& reply) override;

void SimulateWebNotificationClose(const std::string& title,

bool by_user) override;

void SetDeviceScaleFactor(float factor) override;