Add layout test for reply property of notificationclick event

components/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/test_runner.h"
 
 #include <stddef.h>
 #include <limits>
 #include <utility>
 
@@ skipping 234 matching lines @@
   void SetTabKeyCyclesThroughElements(bool tab_key_cycles_through_elements);
   void SetTextDirection(const std::string& direction_name);
   void SetTextSubpixelPositioning(bool value);
   void SetUseMockTheme(bool use);
   void SetViewSourceForFrame(const std::string& name, bool enabled);
   void SetWillSendRequestClearHeader(const std::string& header);
   void SetWindowIsKey(bool value);
   void SetXSSAuditorEnabled(bool enabled);
   void ShowWebInspector(gin::Arguments* args);
   void SimulateWebNotificationClick(const std::string& title, int action_index);
+  void SimulateWebNotificationClickWithReply(const std::string& title,
+                                             int action_index,
+                                             const std::string& reply);
   void SimulateWebNotificationClose(const std::string& title, bool by_user);
   void UseUnfortunateSynchronousResizeMode();
   void WaitForPolicyDelegate();
   void WaitUntilDone();
   void WaitUntilExternalURLLoad();
   void SetMockCredentialManagerError(const std::string& error);
   void SetMockCredentialManagerResponse(const std::string& id,
                                         const std::string& name,
                                         const std::string& avatar,
                                         const std::string& password);
@@ skipping 304 matching lines @@
       .SetMethod("setViewSourceForFrame",
                  &TestRunnerBindings::SetViewSourceForFrame)
       .SetMethod("setWillSendRequestClearHeader",
                  &TestRunnerBindings::SetWillSendRequestClearHeader)
       .SetMethod("setWindowIsKey", &TestRunnerBindings::SetWindowIsKey)
       .SetMethod("setXSSAuditorEnabled",
                  &TestRunnerBindings::SetXSSAuditorEnabled)
       .SetMethod("showWebInspector", &TestRunnerBindings::ShowWebInspector)
       .SetMethod("simulateWebNotificationClick",
                  &TestRunnerBindings::SimulateWebNotificationClick)
+      .SetMethod("simulateWebNotificationClickWithReply",
+                 &TestRunnerBindings::SimulateWebNotificationClickWithReply)
       .SetMethod("simulateWebNotificationClose",
                  &TestRunnerBindings::SimulateWebNotificationClose)
       .SetProperty("tooltipText", &TestRunnerBindings::TooltipText)
       .SetMethod("useUnfortunateSynchronousResizeMode",
                  &TestRunnerBindings::UseUnfortunateSynchronousResizeMode)
       .SetMethod("waitForPolicyDelegate",
                  &TestRunnerBindings::WaitForPolicyDelegate)
       .SetMethod("waitUntilDone", &TestRunnerBindings::WaitUntilDone)
       .SetMethod("waitUntilExternalURLLoad",
                  &TestRunnerBindings::WaitUntilExternalURLLoad)
@@ skipping 761 matching lines @@
 
 void TestRunnerBindings::SetMIDIAccessorResult(bool result) {
   if (runner_)
     runner_->SetMIDIAccessorResult(result);
 }
 
 void TestRunnerBindings::SimulateWebNotificationClick(const std::string& title,
                                                       int action_index) {
   if (!runner_)
     return;
-  runner_->SimulateWebNotificationClick(title, action_index);
+  runner_->SimulateWebNotificationClick(title, action_index, "");
+}
+
+void TestRunnerBindings::SimulateWebNotificationClickWithReply(

[Peter Beverloo, 2016/10/11 14:28:39]

Ah, yeah, this is a fine middle ground :-).

Depending on whether you agree on the base::NullableString16 comment in
the other CL, we probably want TestRunner::SimulateWebNotificationClick()'s
|reply| to argument to be of that type too?

[awdf, 2016/10/12 14:59:45]

Done.

+    const std::string& title,
+    int action_index,
+    const std::string& reply) {
+  if (!runner_)
+    return;
+  runner_->SimulateWebNotificationClick(title, action_index, reply);
 }
 
 void TestRunnerBindings::SimulateWebNotificationClose(const std::string& title,
                                                       bool by_user) {
   if (!runner_)
     return;
   runner_->SimulateWebNotificationClose(title, by_user);
 }
 
 void TestRunnerBindings::AddMockSpeechRecognitionResult(
@@ skipping 1308 matching lines @@
 
 void TestRunner::SetPOSIXLocale(const std::string& locale) {
   delegate_->SetLocale(locale);
 }
 
 void TestRunner::SetMIDIAccessorResult(bool result) {
   midi_accessor_result_ = result;
 }
 
 void TestRunner::SimulateWebNotificationClick(const std::string& title,
-                                              int action_index) {
-  delegate_->SimulateWebNotificationClick(title, action_index);
+                                              int action_index,
+                                              const std::string& reply) {
+  delegate_->SimulateWebNotificationClick(title, action_index, reply);
 }
 
 void TestRunner::SimulateWebNotificationClose(const std::string& title,
                                               bool by_user) {
   delegate_->SimulateWebNotificationClose(title, by_user);
 }
 
 void TestRunner::AddMockSpeechRecognitionResult(const std::string& transcript,
                                                 double confidence) {
   getMockWebSpeechRecognizer()->AddMockResult(WebString::fromUTF8(transcript),
@@ skipping 69 matching lines @@
 
 void TestRunner::NotifyDone() {
   if (layout_test_runtime_flags_.wait_until_done() && !topLoadingFrame() &&
       !will_navigate_ && work_queue_.is_empty())
     delegate_->TestFinished();
   layout_test_runtime_flags_.set_wait_until_done(false);
   OnLayoutTestRuntimeFlagsChanged();
 }
 
 }  // namespace test_runner