Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2403863002:
added SkSL to Skia build (Closed)
|
Created:
4 years, 2 months ago by ethannicholas Modified:
4 years, 2 months ago CC:
pdfium-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
pdfium Visibility:
Public. |
Descriptionadded SkSL to Skia build
This fixes a pfdium build error when using the Skia backend, due to new Skia files which are not being properly included in the pdfium build.
Committed: https://pdfium.googlesource.com/pdfium/+/52ef14e8911f0502b251d1f2ea205f17565a2440
Patch Set 1 #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by ethannicholas@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-pdfium-committers". Note that this has nothing to do with OWNERS files.
ethannicholas@google.com changed reviewers: + caryclark@google.com, msarett@google.com
lgtm
The CQ bit was checked by ethannicholas@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-pdfium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== added SkSL to Skia build BUG= ========== to ========== added SkSL to Skia build TBR=caryclark@google.com ==========
The CQ bit was checked by ethannicholas@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-pdfium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== added SkSL to Skia build TBR=caryclark@google.com ========== to ========== added SkSL to Skia build ==========
ethannicholas@google.com changed reviewers: + dsinclair@chromium.org
What is SkSL? Can you update the description on why this is needed?
Description was changed from ========== added SkSL to Skia build ========== to ========== added SkSL to Skia build This fixes a pfdium build error when using the Skia backend, due to new Skia files which are not being properly included in the pdfium build. ==========
Updated description.
The CQ bit was checked by dsinclair@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== added SkSL to Skia build This fixes a pfdium build error when using the Skia backend, due to new Skia files which are not being properly included in the pdfium build. ========== to ========== added SkSL to Skia build This fixes a pfdium build error when using the Skia backend, due to new Skia files which are not being properly included in the pdfium build. Committed: https://pdfium.googlesource.com/pdfium/+/52ef14e8911f0502b251d1f2ea205f17565a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/52ef14e8911f0502b251d1f2ea205f17565a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
