Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240383003: allow gyp_skia to be run from any directory. (Closed)

Created:
6 years, 8 months ago by hal.canary
Modified:
6 years, 8 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

allow gyp_skia to be run from any directory. Committed: http://code.google.com/p/skia/source/detail?r=14239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp_skia View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
ptal
6 years, 8 months ago (2014-04-16 21:34:02 UTC) #1
epoger
LGTM* * - I'm fine with the change, but in my experience (a couple years ...
6 years, 8 months ago (2014-04-17 14:03:20 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-17 14:15:32 UTC) #3
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 8 months ago (2014-04-17 14:15:35 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-17 16:11:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/240383003/1
6 years, 8 months ago (2014-04-17 16:11:48 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 16:12:11 UTC) #7
Message was sent while issue was closed. 
Change committed as 14239

Powered by Google App Engine
This is Rietveld 408576698