Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2403823002: [wasm] Base address for data segments can also be the value of a global variable. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Base address for data segments can also be the value of a global variable. R=rossberg@chromium.org BUG=chromium:575167 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 Committed: https://crrev.com/d20dabb090ea70b0b1fa3b9ebc5a69149669ab3b Cr-Original-Commit-Position: refs/heads/master@{#40121} Cr-Commit-Position: refs/heads/master@{#40125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -16 lines) Patch
M src/wasm/wasm-module.cc View 7 chunks +27 lines, -11 lines 0 comments Download
A test/mjsunit/wasm/data-segments.js View 1 chunk +90 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
titzer
4 years, 2 months ago (2016-10-10 12:16:12 UTC) #1
rossberg
lgtm
4 years, 2 months ago (2016-10-10 13:20:43 UTC) #6
rossberg
lgtm lgtm
4 years, 2 months ago (2016-10-10 13:20:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403823002/1
4 years, 2 months ago (2016-10-10 13:23:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 13:25:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 Cr-Commit-Position: refs/heads/master@{#40121}
4 years, 2 months ago (2016-10-10 13:26:37 UTC) #12
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2402373002/ by machenbach@chromium.org. ...
4 years, 2 months ago (2016-10-10 14:12:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403823002/1
4 years, 2 months ago (2016-10-10 14:16:54 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 14:41:53 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:42:17 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20dabb090ea70b0b1fa3b9ebc5a69149669ab3b
Cr-Commit-Position: refs/heads/master@{#40125}

Powered by Google App Engine
This is Rietveld 408576698