Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 2403803002: [X87] [crankshaft] Set Floating-point precision in Math.Cos/Math.Sin to standard double precision. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [crankshaft] Set Floating-point precision in Math.Cos/Math.Sin to standard double precision. This CL set Floating-point precision in Math.Cos/Math.Sin in Crankshaft compiler to standard double precision which is expected by v8. BUG= Committed: https://crrev.com/ecc7d969eaa041895d447f787711133b372894ac Cr-Commit-Position: refs/heads/master@{#40146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-10 10:53:26 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-11 01:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403803002/1
4 years, 2 months ago (2016-10-11 01:46:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 02:13:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 02:14:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecc7d969eaa041895d447f787711133b372894ac
Cr-Commit-Position: refs/heads/master@{#40146}

Powered by Google App Engine
This is Rietveld 408576698