git cl patch: handle missing/wrong Gerrit issue better.

git cl patch: handle missing/wrong Gerrit issue better.

No stacktrace is printed, instead just a user-friendly string is shown.
Add test + some tests refactoring.

This CL also improve missing Gerrit issue exception elsewhere by raising
user-friendly exception.

BUG=654360
R=sergiyb@chromium.org
TEST=manual

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2405f5545288efe2cad1293ac106b189bbbed5f

[tandrii(chromium), 2016-10-10 09:50:36]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 09:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 09:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 09:53:48]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-10-10 11:41:12]

lgtm

https://codereview.chromium.org/2403793002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2403793002/diff/1/git_cl.py#newcode980
git_cl.py:980: class GerritIssueNotExists(Exception):
IMHO it should be either GerritIssueExistsNot or GerritIssueDoesNotExist. Up to
you.

https://codereview.chromium.org/2403793002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (left):

https://codereview.chromium.org/2403793002/diff/1/tests/git_cl_test.py#oldcod...
tests/git_cl_test.py:719: except SystemExit:
nice refactor

[tandrii(chromium), 2016-10-10 15:10:14]

https://codereview.chromium.org/2403793002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2403793002/diff/1/git_cl.py#newcode980
git_cl.py:980: class GerritIssueNotExists(Exception):
On 2016/10/10 11:41:11, Sergiy Byelozyorov wrote:
> IMHO it should be either GerritIssueExistsNot or GerritIssueDoesNotExist. Up
to
> you.

I appreciate your review, but I think NotExists is easier to read and 
http://cs/search/?q=NotExists(Exception) vs
http://cs/search/?q=ExistsNot(Exception)

https://codereview.chromium.org/2403793002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (left):

https://codereview.chromium.org/2403793002/diff/1/tests/git_cl_test.py#oldcod...
tests/git_cl_test.py:719: except SystemExit:
On 2016/10/10 11:41:12, Sergiy Byelozyorov wrote:
> nice refactor

:)

[tandrii(chromium), 2016-10-10 15:10:19]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-10-10 15:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 15:13:17]

Description was changed from

==========
git cl patch: handle missing/wrong Gerrit issue better.

No stacktrace is printed, instead just a user-friendly string is shown.
Add test + some tests refactoring.

This CL also improve missing Gerrit issue exception elsewhere by raising
user-friendly exception.

BUG=654360
R=sergiyb@chromium.org
TEST=manual
==========

to

==========
git cl patch: handle missing/wrong Gerrit issue better.

No stacktrace is printed, instead just a user-friendly string is shown.
Add test + some tests refactoring.

This CL also improve missing Gerrit issue exception elsewhere by raising
user-friendly exception.

BUG=654360
R=sergiyb@chromium.org
TEST=manual

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2405f5545288e...
==========

[commit-bot: I haz the power, 2016-10-10 15:13:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c2405f5545288e...