[Mac] Address buggy permission bubble behaviour on dismissal via ESC.

chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index 7045b6cf219a066dae2f2932bfa0131c476846f2..6a422d2db63c5b9f761aa3aa8baa885e33be2ef7 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -394,10 +394,7 @@ void PermissionsBubbleDialogDelegateView::UpdateAnchor(
 PermissionPromptImpl::PermissionPromptImpl(Browser* browser)
     : browser_(browser),
       delegate_(nullptr),
-      bubble_delegate_(nullptr) {
-  DCHECK(browser);
-  DCHECK(browser->window());
-}
+      bubble_delegate_(nullptr) {}

[hcarmona, 2016/10/10 18:08:19]

Same here.

[dominickn, 2016/10/10 22:55:48]

See other comment

 
 PermissionPromptImpl::~PermissionPromptImpl() {
 }
@@ -408,6 +405,9 @@ void PermissionPromptImpl::SetDelegate(Delegate* delegate) {
 
 void PermissionPromptImpl::Show(const std::vector<PermissionRequest*>& requests,
                                 const std::vector<bool>& values) {
+  DCHECK(browser_);
+  DCHECK(browser_->window());
+
   if (bubble_delegate_)
     bubble_delegate_->CloseBubble();
 
@@ -442,6 +442,9 @@ bool PermissionPromptImpl::IsVisible() {
 }
 
 void PermissionPromptImpl::UpdateAnchorPosition() {
+  DCHECK(browser_);
+  DCHECK(browser_->window());
+
   if (IsVisible()) {
     bubble_delegate_->set_parent_window(
         platform_util::GetViewForWindow(browser_->window()->GetNativeWindow()));