Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4126)

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)
Patch Set: Override [cancel] instead of [dealloc] Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_manager.h
diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h
index def150e1a9606b7fe9b8f6fa147475115d17db07..bee959bb6c46aa320ba991c3a0f9626d47f9bf7c 100644
--- a/chrome/browser/permissions/permission_request_manager.h
+++ b/chrome/browser/permissions/permission_request_manager.h
@@ -70,7 +70,13 @@ class PermissionRequestManager
// at which time the caller is free to delete the request.
void CancelRequest(PermissionRequest* request);
- // Hides the bubble.
+ // Dismisses the bubble if it is visible, as if the user had clicked the X in
+ // the prompt. Then hides the bubble and destroys the UI surface.
+ void DismissBubble();
+
+ // Hides the bubble, and destroys the UI surface used to display the
+ // permission requests. DisplayPendingRequests or a navigation must occur
+ // before another bubble will be shown.
void HideBubble();
felt 2016/10/10 18:21:00 Do we *ever* want this behavior? Should we get rid
hcarmona 2016/10/10 18:28:51 |HideBubble| is used when switching tabs to hide t
dominickn 2016/10/10 22:55:48 I clarified the comment here.
hcarmona 2016/10/11 14:45:33 Thanks!
// Will show a permission bubble if there is a pending permission request on

Powered by Google App Engine
This is Rietveld 408576698