Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
index bc593c1bfb61cda12898ea55b013bb008f06be50..655519a79266f3ad9e2b564323651ae18cfcfcee 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
@@ -225,6 +225,9 @@ const NSInteger kFullscreenLeftOffset = 40;
// vertical center of |viewB|.
+ (void)alignCenterOf:(NSView*)viewA verticallyToCenterOf:(NSView*)viewB;
+// BaseBubbleController override.
+- (IBAction)cancel:(id)sender;
+
@end
@implementation PermissionBubbleController
@@ -660,4 +663,11 @@ const NSInteger kFullscreenLeftOffset = 40;
[viewA setFrameOrigin:frameA.origin];
}
+- (IBAction)cancel:(id)sender {
+ // This is triggered by ESC when the bubble has focus.
+ DCHECK(delegate_);
+ delegate_->Closing();
+ [super cancel:sender];
+}
+
@end // implementation PermissionBubbleController

Powered by Google App Engine
This is Rietveld 408576698