Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2403733002: Implement BazelPackageUriResolver.restoreAbsolute(). (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement BazelPackageUriResolver.restoreAbsolute(). It is mostly tested with the same tests as for resolveAbsolute(). R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4511504171a7fdbfb31037154cffbd1f5606c1bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 2 chunks +48 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 4 chunks +67 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-09 22:44:59 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-09 23:22:55 UTC) #2
scheglov
4 years, 2 months ago (2016-10-10 15:16:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4511504171a7fdbfb31037154cffbd1f5606c1bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698