Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2403723002: Add more tests for BazelPackageUriResolver.resolveAbsolute(). (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more tests for BazelPackageUriResolver.resolveAbsolute(). Create separate set of resources in each test in order to simplify the tests. Fix the case when files are generated for third_party/dart/XXX. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/78051dc47d3671bcf2b4f17c83c33b556193393a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -51 lines) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 2 chunks +3 lines, -11 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 chunk +261 lines, -40 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-09 20:59:15 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2403723002/diff/1/pkg/analyzer/test/generated/bazel_test.dart File pkg/analyzer/test/generated/bazel_test.dart (right): https://codereview.chromium.org/2403723002/diff/1/pkg/analyzer/test/generated/bazel_test.dart#newcode398 pkg/analyzer/test/generated/bazel_test.dart:398: provider.newFile(_p(path), ''); If "_p" is only invoked twice, ...
4 years, 2 months ago (2016-10-09 21:35:36 UTC) #2
scheglov
4 years, 2 months ago (2016-10-09 21:40:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78051dc47d3671bcf2b4f17c83c33b556193393a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698