Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 24037003: Fix bitwise negation on x64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-285355.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1407 matching lines...) Expand 10 before | Expand all | Expand 10 after
1418 int32_t right_operand = ToInteger32(LConstantOperand::cast(right)); 1418 int32_t right_operand = ToInteger32(LConstantOperand::cast(right));
1419 switch (instr->op()) { 1419 switch (instr->op()) {
1420 case Token::BIT_AND: 1420 case Token::BIT_AND:
1421 __ andl(ToRegister(left), Immediate(right_operand)); 1421 __ andl(ToRegister(left), Immediate(right_operand));
1422 break; 1422 break;
1423 case Token::BIT_OR: 1423 case Token::BIT_OR:
1424 __ orl(ToRegister(left), Immediate(right_operand)); 1424 __ orl(ToRegister(left), Immediate(right_operand));
1425 break; 1425 break;
1426 case Token::BIT_XOR: 1426 case Token::BIT_XOR:
1427 if (right_operand == int32_t(~0)) { 1427 if (right_operand == int32_t(~0)) {
1428 __ not_(ToRegister(left)); 1428 __ notl(ToRegister(left));
1429 } else { 1429 } else {
1430 __ xorl(ToRegister(left), Immediate(right_operand)); 1430 __ xorl(ToRegister(left), Immediate(right_operand));
1431 } 1431 }
1432 break; 1432 break;
1433 default: 1433 default:
1434 UNREACHABLE(); 1434 UNREACHABLE();
1435 break; 1435 break;
1436 } 1436 }
1437 } else if (right->IsStackSlot()) { 1437 } else if (right->IsStackSlot()) {
1438 switch (instr->op()) { 1438 switch (instr->op()) {
(...skipping 4111 matching lines...) Expand 10 before | Expand all | Expand 10 after
5550 FixedArray::kHeaderSize - kPointerSize)); 5550 FixedArray::kHeaderSize - kPointerSize));
5551 __ bind(&done); 5551 __ bind(&done);
5552 } 5552 }
5553 5553
5554 5554
5555 #undef __ 5555 #undef __
5556 5556
5557 } } // namespace v8::internal 5557 } } // namespace v8::internal
5558 5558
5559 #endif // V8_TARGET_ARCH_X64 5559 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-285355.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698