Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: third_party/WebKit/Source/devtools/front_end/devtools.js

Issue 2403633002: [DevTools] Move sanitize url to devtools_ui.cc. (Closed)
Patch Set: disable test on android and ios - there is no devtools_ui Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/devtools.js
diff --git a/third_party/WebKit/Source/devtools/front_end/devtools.js b/third_party/WebKit/Source/devtools/front_end/devtools.js
index 3d2d29a85f188066e4b4d6ce5c3c29398ff7b64a..1ef19d9942f7a453061dfd82021dbffb566d6706 100644
--- a/third_party/WebKit/Source/devtools/front_end/devtools.js
+++ b/third_party/WebKit/Source/devtools/front_end/devtools.js
@@ -992,30 +992,6 @@ function installObjectObserve()
window.Object.observe = objectObserve;
}
-/**
- * @suppressGlobalPropertiesCheck
- */
-function sanitizeRemoteFrontendUrl()
-{
- var remoteBaseRegexp = /^https:\/\/chrome-devtools-frontend\.appspot\.com\/serve_file\/@[0-9a-zA-Z]+\/?$/;
- var remoteFrontendUrlRegexp = /^https:\/\/chrome-devtools-frontend\.appspot\.com\/serve_rev\/@?[0-9a-zA-Z]+\/(devtools|inspector)\.html$/;
- var queryParams = location.search;
- if (!queryParams)
- return;
- var params = queryParams.substring(1).split("&");
- for (var i = 0; i < params.length; ++i) {
- var pair = params[i].split("=");
- var name = pair.shift();
- var value = pair.join("=");
- if (name === "remoteFrontendUrl" && !remoteFrontendUrlRegexp.test(value))
- location.search = "";
- if (name === "remoteBase" && !remoteBaseRegexp.test(value))
- location.search = "";
- if (name === "settings")
- location.search = "";
- }
-}
-
var staticKeyIdentifiers = new Map([
[0x12, "Alt"],
[0x11, "Control"],
@@ -1094,8 +1070,6 @@ function keyCodeToKeyIdentifier(keyCode)
*/
function installBackwardsCompatibility()
{
- sanitizeRemoteFrontendUrl();
-
if (window.location.search.indexOf("remoteFrontend") === -1)
return;
@@ -1170,14 +1144,11 @@ function windowLoaded()
installBackwardsCompatibility();
}
-sanitizeRemoteFrontendUrl();
if (window.document.head && (window.document.readyState === "complete" || window.document.readyState === "interactive"))
installBackwardsCompatibility();
else
window.addEventListener("DOMContentLoaded", windowLoaded, false);
-})(window);
-
if (!DOMTokenList.prototype.__originalDOMTokenListToggle) {
DOMTokenList.prototype.__originalDOMTokenListToggle = DOMTokenList.prototype.toggle;
DOMTokenList.prototype.toggle = function(token, force)
@@ -1187,3 +1158,5 @@ if (!DOMTokenList.prototype.__originalDOMTokenListToggle) {
return this.__originalDOMTokenListToggle(token, !!force);
}
}
+
+})(window);

Powered by Google App Engine
This is Rietveld 408576698