Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3002)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2403633002: [DevTools] Move sanitize url to devtools_ui.cc. (Closed)
Patch Set: disable test on android and ios - there is no devtools_ui Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/devtools_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 7875ce06d8b2d1f2fc4ab5d300c0b3b378c5d356..dd38dabf07b3062fc7505d48d31db84e6e827cd1 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -204,10 +204,8 @@ GURL DecorateFrontendURL(const GURL& base_url) {
url_string += "&experiments=true";
if (command_line->HasSwitch(switches::kDevToolsFlags)) {
- std::string flags = command_line->GetSwitchValueASCII(
- switches::kDevToolsFlags);
- flags = net::EscapeQueryParamValue(flags, false);
- url_string += "&flags=" + flags;
+ url_string += "&" + command_line->GetSwitchValueASCII(
+ switches::kDevToolsFlags);
}
#if defined(DEBUG_DEVTOOLS)
@@ -902,7 +900,7 @@ GURL DevToolsWindow::GetDevToolsURL(Profile* profile,
}
if (can_dock)
url_string += "&can_dock=true";
- return GURL(url_string);
+ return DevToolsUI::SanitizeFrontendURL(GURL(url_string));
}
// static
« no previous file with comments | « no previous file | chrome/browser/ui/webui/devtools_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698