Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2403623002: Skip over the URL input when the NTP is used for the Home Button. (Closed)

Created:
4 years, 2 months ago by hcarmona
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip over the URL input when the NTP is used for the Home Button. BUG=633915 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/046c41c1e58ebe49924a2628dc2cb0a3eee9fbd0 Cr-Commit-Position: refs/heads/master@{#424745}

Patch Set 1 #

Total comments: 1

Patch Set 2 : put quotes and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.js View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
hcarmona
PTAL
4 years, 2 months ago (2016-10-08 00:47:33 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/2403623002/diff/1/chrome/browser/resources/settings/controls/settings_input.html File chrome/browser/resources/settings/controls/settings_input.html (right): https://codereview.chromium.org/2403623002/diff/1/chrome/browser/resources/settings/controls/settings_input.html#newcode22 chrome/browser/resources/settings/controls/settings_input.html:22: tabindex$=[[getTabindex_(canTab)]]> put quotes around this I.e. tabindex="[[...]]"
4 years, 2 months ago (2016-10-12 06:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403623002/20001
4 years, 2 months ago (2016-10-12 14:40:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 15:39:26 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:41:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/046c41c1e58ebe49924a2628dc2cb0a3eee9fbd0
Cr-Commit-Position: refs/heads/master@{#424745}

Powered by Google App Engine
This is Rietveld 408576698