Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 24036002: Some thread data simplifications. (Closed)

Created:
7 years, 3 months ago by Sven Panne
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use Mutex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -35 lines) Patch
M src/isolate.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/isolate.cc View 1 5 chunks +8 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years, 3 months ago (2013-09-06 12:48:52 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/24036002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/24036002/diff/1/src/isolate.cc#newcode359 src/isolate.cc:359: thread_data_table_->Insert(per_thread); With this change, the process_wide_mutex_ can be turned ...
7 years, 3 months ago (2013-09-06 12:54:08 UTC) #2
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-06 13:17:46 UTC) #3
Sven Panne
7 years, 3 months ago (2013-09-06 13:18:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16577.

Powered by Google App Engine
This is Rietveld 408576698