Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2403583002: More changes to support hermetic Xcode toolchain in GN. (Closed)
Patch Set: Comments from thakis. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/build/scripts/scripts.gni ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 82874c1759b6027fdd9349d9f664ce7321778f2b..871b60e3dccbefdf8415e090c152ee8e67e19d8f 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -719,6 +719,12 @@ action("make_core_generated_css_tokenizer_codepoints") {
"--output_dir",
rel_blink_core_gen_dir,
]
+ if (is_mac && !use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
deps = make_core_generated_deps
}
@@ -742,6 +748,12 @@ action("make_core_generated_css_primitive_value_unit_trie") {
"--output_dir",
rel_blink_core_gen_dir,
]
+ if (is_mac && !use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
deps = make_core_generated_deps
}
@@ -767,6 +779,12 @@ action("make_core_generated_html_element_lookup_trie") {
"--output_dir",
rel_blink_core_gen_dir,
]
+ if (is_mac && !use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
deps = make_core_generated_deps
}
@@ -790,6 +808,12 @@ action("make_core_generated_origin_trials") {
"--output_dir",
"$rel_blink_core_gen_dir/origin_trials",
]
+ if (is_mac && !use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
}
action_foreach("make_core_generated_bison") {
@@ -806,7 +830,7 @@ action_foreach("make_core_generated_bison") {
rel_blink_core_gen_dir,
bison_exe,
]
- if (!use_system_xcode) {
+ if (is_mac && !use_system_xcode) {
args += [ hermetic_xcode_path ]
}
« no previous file with comments | « third_party/WebKit/Source/build/scripts/scripts.gni ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698