Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2403573002: cc: Introduce mechanism to observe CompositorFrames submitted to new surfaceIDs (Closed)
Patch Set: Updated changes missed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 531dedfc6a7088848e864712460e4cfa2b54e144..b3f77735c48aef23bf470f9cf60473d7a813db97 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -248,8 +248,12 @@ class TestWindowObserver : public aura::WindowObserver {
DISALLOW_COPY_AND_ASSIGN(TestWindowObserver);
};
-class FakeSurfaceDamageObserver : public cc::SurfaceDamageObserver {
+class FakeSurfaceObserver : public cc::SurfaceObserver {
public:
+ void OnSurfaceCreated(const cc::SurfaceId& surface_id,
+ const gfx::Size& frame,
+ float device_scale_factor) override {}
+
void OnSurfaceDamaged(const cc::SurfaceId& id, bool* changed) override {
*changed = true;
}
@@ -1675,10 +1679,10 @@ cc::CompositorFrame MakeDelegatedFrame(float scale_factor,
// client in response to the swap. This test verifies that the returned
// resources are indeed reported as being in response to a swap.
TEST_F(RenderWidgetHostViewAuraTest, ResettingCompositorReturnsResources) {
- FakeSurfaceDamageObserver damage_observer;
+ FakeSurfaceObserver manager_observer;
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
cc::SurfaceManager* manager = factory->GetSurfaceManager();
- manager->AddObserver(&damage_observer);
+ manager->AddObserver(&manager_observer);
gfx::Size view_size(100, 100);
gfx::Rect view_rect(view_size);
@@ -1706,7 +1710,7 @@ TEST_F(RenderWidgetHostViewAuraTest, ResettingCompositorReturnsResources) {
EXPECT_EQ(0u, std::get<0>(params)); // compositor_frame_sink_id
EXPECT_TRUE(std::get<1>(params)); // is_swap_ack
}
- manager->RemoveObserver(&damage_observer);
+ manager->RemoveObserver(&manager_observer);
}
// This test verifies that returned resources do not require a pending ack.
@@ -1742,10 +1746,10 @@ TEST_F(RenderWidgetHostViewAuraTest, ReturnedResources) {
// This test verifies that when the compositor_frame_sink_id changes, then
// DelegateFrameHost returns compositor resources without a swap ack.
TEST_F(RenderWidgetHostViewAuraTest, TwoOutputSurfaces) {
- FakeSurfaceDamageObserver damage_observer;
+ FakeSurfaceObserver manager_observer;
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
cc::SurfaceManager* manager = factory->GetSurfaceManager();
- manager->AddObserver(&damage_observer);
+ manager->AddObserver(&manager_observer);
gfx::Size view_size(100, 100);
gfx::Rect view_rect(view_size);
@@ -1799,7 +1803,7 @@ TEST_F(RenderWidgetHostViewAuraTest, TwoOutputSurfaces) {
EXPECT_EQ(true, std::get<1>(params)); // is_swap_ack
}
- manager->RemoveObserver(&damage_observer);
+ manager->RemoveObserver(&manager_observer);
}
// Resizing in fullscreen mode should send the up-to-date screen info.
« no previous file with comments | « cc/surfaces/surface_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698