Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2403553002: reflow comments in core/layout/[M-Z]*.{cpp,h} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
eae, dcheng
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/layout/[M-Z]*.{cpp,h} BUG=563793 Committed: https://crrev.com/e32a7e3865d11aa1e3742f9438ddb9fd0ca79cf5 Cr-Commit-Position: refs/heads/master@{#423960}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -363 lines) Patch
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 11 chunks +31 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h View 7 chunks +31 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 18 chunks +97 lines, -76 lines 1 comment Download
M third_party/WebKit/Source/core/layout/OverflowModel.h View 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaginationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintContainmentTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 5 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 11 chunks +71 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAlignment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAlignment.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp View 20 chunks +56 lines, -33 lines 2 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp View 6 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 5 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 24 chunks +73 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 7 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 15 chunks +39 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
4 years, 2 months ago (2016-10-07 19:07:03 UTC) #2
dcheng
LGTM https://codereview.chromium.org/2403553002/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp File third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp (right): https://codereview.chromium.org/2403553002/diff/1/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp#newcode586 third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp:586: // operator=. o.O https://codereview.chromium.org/2403553002/diff/1/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp File third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp (right): https://codereview.chromium.org/2403553002/diff/1/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp#newcode332 ...
4 years, 2 months ago (2016-10-07 20:42:01 UTC) #8
Nico
Thanks!
4 years, 2 months ago (2016-10-07 20:46:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403553002/1
4 years, 2 months ago (2016-10-07 20:47:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 20:53:14 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e32a7e3865d11aa1e3742f9438ddb9fd0ca79cf5 Cr-Commit-Position: refs/heads/master@{#423960}
4 years, 2 months ago (2016-10-07 20:55:30 UTC) #14
eae
4 years, 2 months ago (2016-10-07 23:46:59 UTC) #15
Message was sent while issue was closed.
LGTM (post-facto)

Powered by Google App Engine
This is Rietveld 408576698