Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2403543002: Add Machine Provider ui parts (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel, smut
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page.html View 1 chunk +10 lines, -0 lines 1 comment Download
M appengine/swarming/elements/res/imp/botpage/bot-page-data.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kjlubick
https://screenshot.googleplex.com/izHWMLVwfof Ready for when https://codereview.chromium.org/2402543002/ lands
4 years, 2 months ago (2016-10-07 18:36:07 UTC) #2
jcgregorio
lgtm
4 years, 2 months ago (2016-10-07 19:06:20 UTC) #3
KevinL
lgtm
4 years, 2 months ago (2016-10-07 19:14:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403543002/1
4 years, 2 months ago (2016-10-07 19:14:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/26703045663c26ed79bf0ce7e9ed8386002a8074
4 years, 2 months ago (2016-10-07 19:18:12 UTC) #9
smut
https://codereview.chromium.org/2403543002/diff/1/appengine/swarming/elements/res/imp/botpage/bot-page.html File appengine/swarming/elements/res/imp/botpage/bot-page.html (right): https://codereview.chromium.org/2403543002/diff/1/appengine/swarming/elements/res/imp/botpage/bot-page.html#newcode237 appengine/swarming/elements/res/imp/botpage/bot-page.html:237: <td colspan=2>[[_bot.lease_id]]</td> Can you linkify this or do I ...
4 years, 2 months ago (2016-10-07 21:43:08 UTC) #11
kjlubick
4 years, 2 months ago (2016-10-08 12:27:09 UTC) #12
Message was sent while issue was closed.
On 2016/10/07 at 21:43:08, smut wrote:
>
https://codereview.chromium.org/2403543002/diff/1/appengine/swarming/elements...
> File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):
> 
>
https://codereview.chromium.org/2403543002/diff/1/appengine/swarming/elements...
> appengine/swarming/elements/res/imp/botpage/bot-page.html:237: <td
colspan=2>[[_bot.lease_id]]</td>
> Can you linkify this or do I need to include that info in the proto?
> 
> Basically the MP URL base needs to be extracted from luci-config (we already
do that and store it in the datastore) and joined with this lease_id to make a
URL to anchor here.
Yes I can link it, but you bring up a good point.

I have a few other places where I just hardcoded something to be used for links
to get it off the ground.

https://github.com/luci/luci-py/blob/d40718cea5e0337cb4bc4fd242e2690accd56ab7...
https://github.com/luci/luci-py/blob/c3c1c43710c301aab00584dd49a150f56dbfd25c...

Now would be a good time to add both of those things to the config proto (I
found the MP URL you mentioned:
https://github.com/luci/luci-py/blob/d40718cea5e0337cb4bc4fd242e2690accd56ab7...)
and then pipe those through an endpoint, somehow.  

Perhaps in the server details API, as that's already called on every page and
then any page could use the links provided there.

Powered by Google App Engine
This is Rietveld 408576698