Mojo C++ Bindings: Support custom impl ref types

Mojo C++ Bindings: Support custom impl ref types

Allows binding primitives to use custom reference types
for their interface implementation.

BUG=654218
Committed: https://crrev.com/8e2a5d2996da6336f3c817eda73da12c7a3c7d84
Cr-Commit-Position: refs/heads/master@{#424118}

[Ken Rockot(use gerrit already), 2016-10-08 16:46:27]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 16:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-08 17:02:17]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 17:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-08 17:02:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-08 17:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 17:28:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2016-10-08 17:34:32]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 17:34:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-08 17:34:43]

Patchset #1 (id:20001) has been deleted

[Ken Rockot(use gerrit already), 2016-10-08 17:44:28]

rockot@chromium.org changed reviewers:
+ sammc@chromium.org, yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-10-08 17:44:29]

PTAL.

+yzshen optional since OOO :)

[Ken Rockot(use gerrit already), 2016-10-08 18:33:15]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 18:33:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 19:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 19:30:05]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-10-09 22:20:01]

LGTM

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/binding_unittest.cc (right):

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/binding_unittest.cc:363:
mojo::Binding<test::PingService> binding_(&impl, GetProxy(&ptr));
nit: it seems unusual to have trailing "_" in the name here.

[Sam McNally, 2016-10-09 22:57:56]

lgtm

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_binding.h (right):

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_binding.h:52: explicit
AssociatedBinding(ImplPointerType impl) { stub_.set_sink(impl); }
Pass by const ref or std::move(impl). I could see this pattern being useful for
refcounted impls and copying would cause some unnecessary refcount churn.

I'm also curious whether StrongBinding could be reimplemented by using
PointerType = std::unique_ptr (with some connection error handler changes to
clean up appropriately).

[Ken Rockot(use gerrit already), 2016-10-10 05:38:28]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 05:38:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-10 05:38:39]

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_binding.h (right):

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_binding.h:52: explicit
AssociatedBinding(ImplPointerType impl) { stub_.set_sink(impl); }
On 2016/10/09 at 22:57:56, Sam McNally wrote:
> Pass by const ref or std::move(impl). I could see this pattern being useful
for refcounted impls and copying would cause some unnecessary refcount churn.
> 
> I'm also curious whether StrongBinding could be reimplemented by using
PointerType = std::unique_ptr (with some connection error handler changes to
clean up appropriately).

Done (std::move)

I had the same thought about StrongBinding, but I was undecided on the best way
to deal with error handling. I suppose we could have Binding itself set an error
handler, calling out to the traits and then optionally forwarding to a user
callback if set.

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/binding_unittest.cc (right):

https://codereview.chromium.org/2403533003/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/binding_unittest.cc:363:
mojo::Binding<test::PingService> binding_(&impl, GetProxy(&ptr));
On 2016/10/09 at 22:20:01, yzshen1 (OOO Sep25-Oct29) wrote:
> nit: it seems unusual to have trailing "_" in the name here.

Oops, copy-paste :)  Fixed

[Ken Rockot(use gerrit already), 2016-10-10 06:28:04]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-10 06:28:06]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-10 06:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org,
yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2403533003/#ps80001
(title: "nit, move")

[commit-bot: I haz the power, 2016-10-10 06:28:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 06:39:03]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-10 06:41:46]

Description was changed from

==========
Mojo C++ Bindings: Support custom impl ref types

Allows binding primitives to use custom reference types
for their interface implementation.

BUG=654218
==========

to

==========
Mojo C++ Bindings: Support custom impl ref types

Allows binding primitives to use custom reference types
for their interface implementation.

BUG=654218

Committed: https://crrev.com/8e2a5d2996da6336f3c817eda73da12c7a3c7d84
Cr-Commit-Position: refs/heads/master@{#424118}
==========

[commit-bot: I haz the power, 2016-10-10 06:41:47]

Patchset 3 (id:??) landed as
https://crrev.com/8e2a5d2996da6336f3c817eda73da12c7a3c7d84
Cr-Commit-Position: refs/heads/master@{#424118}