VideoCaptureHostTest: simplify testing and remove unused code

VideoCaptureHostTest: simplify testing and remove unused code

This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.

Committed: https://crrev.com/fe85428bd742a61f78db005f980b15c219c4464d
Cr-Commit-Position: refs/heads/master@{#423988}

[mcasas, 2016-10-07 18:16:40]

Description was changed from

==========
VideoCaptureHostTest: simplify testing and remove unused code

BUG=651897
==========

to

==========
VideoCaptureHostTest: simplify testing and remove unused code

BUG=651897, 651937
==========

[mcasas, 2016-10-07 18:19:39]

Description was changed from

==========
VideoCaptureHostTest: simplify testing and remove unused code

BUG=651897, 651937
==========

to

==========
VideoCaptureHostTest: simplify testing and remove unused code


This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we 
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.
==========

[mcasas, 2016-10-07 18:24:51]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-10-07 18:24:51]

xianglu@ PTAL

[mcasas, 2016-10-07 18:38:33]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:38:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-10-07 19:35:08]

lgtm with comments.

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_host_unittest.cc (right):

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_host_unittest.cc:111: int
buffer_id = *buffer_ids_.begin();
Might be better to use buffer_ids_.front() so no need for referencing?

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_host_unittest.cc:400:
//|audio_manager_| needs to outlive |thread_bundle_| because it uses the
nit: missing one space

[commit-bot: I haz the power, 2016-10-07 19:38:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:38:31]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-10-07 21:41:46]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-10-07 21:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from xianglu@chromium.org
Link to the patchset: https://codereview.chromium.org/2403533002/#ps20001
(title: "xianglu@ comments")

[mcasas, 2016-10-07 21:41:52]

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_host_unittest.cc (right):

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_host_unittest.cc:111: int
buffer_id = *buffer_ids_.begin();
On 2016/10/07 19:35:08, xianglu wrote:
> Might be better to use buffer_ids_.front() so no need for referencing?

Done.

https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_host_unittest.cc:400:
//|audio_manager_| needs to outlive |thread_bundle_| because it uses the
On 2016/10/07 19:35:08, xianglu wrote:
> nit: missing one space

Done.

[commit-bot: I haz the power, 2016-10-07 21:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:30:35]

Description was changed from

==========
VideoCaptureHostTest: simplify testing and remove unused code


This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we 
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.
==========

to

==========
VideoCaptureHostTest: simplify testing and remove unused code


This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we 
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.
==========

[commit-bot: I haz the power, 2016-10-07 22:30:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 22:31:54]

Description was changed from

==========
VideoCaptureHostTest: simplify testing and remove unused code


This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we 
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.
==========

to

==========
VideoCaptureHostTest: simplify testing and remove unused code

This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG=651897, 651937
TEST=no new production code, just unittest cleanup.

Committed: https://crrev.com/fe85428bd742a61f78db005f980b15c219c4464d
Cr-Commit-Position: refs/heads/master@{#423988}
==========

[commit-bot: I haz the power, 2016-10-07 22:31:56]

Patchset 2 (id:??) landed as
https://crrev.com/fe85428bd742a61f78db005f980b15c219c4464d
Cr-Commit-Position: refs/heads/master@{#423988}