Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2403533002: VideoCaptureHostTest: simplify testing and remove unused code (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
Reviewers:
xianglu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureHostTest: simplify testing and remove unused code This CL cleans up the VideoCaptureHostTest code: - removes unused DUMP video support - removes possibility of using real cameras (we have content_browsertests and browser_tests for it) - removes actual ShMem mapping and bookkeeping in MockVideoCaptureHost, because is not needed (we just need the ids). BUG=651897, 651937 TEST=no new production code, just unittest cleanup. Committed: https://crrev.com/fe85428bd742a61f78db005f980b15c219c4464d Cr-Commit-Position: refs/heads/master@{#423988}

Patch Set 1 #

Total comments: 4

Patch Set 2 : xianglu@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -148 lines) Patch
M content/browser/renderer_host/media/video_capture_host.cc View 1 4 chunks +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 15 chunks +30 lines, -143 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
mcasas
xianglu@ PTAL
4 years, 2 months ago (2016-10-07 18:24:51 UTC) #4
xianglu
lgtm with comments. https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_host/media/video_capture_host_unittest.cc File content/browser/renderer_host/media/video_capture_host_unittest.cc (right): https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_host/media/video_capture_host_unittest.cc#newcode111 content/browser/renderer_host/media/video_capture_host_unittest.cc:111: int buffer_id = *buffer_ids_.begin(); Might be ...
4 years, 2 months ago (2016-10-07 19:35:08 UTC) #7
mcasas
https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_host/media/video_capture_host_unittest.cc File content/browser/renderer_host/media/video_capture_host_unittest.cc (right): https://codereview.chromium.org/2403533002/diff/1/content/browser/renderer_host/media/video_capture_host_unittest.cc#newcode111 content/browser/renderer_host/media/video_capture_host_unittest.cc:111: int buffer_id = *buffer_ids_.begin(); On 2016/10/07 19:35:08, xianglu wrote: ...
4 years, 2 months ago (2016-10-07 21:41:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403533002/20001
4 years, 2 months ago (2016-10-07 21:42:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 22:30:36 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 22:31:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe85428bd742a61f78db005f980b15c219c4464d
Cr-Commit-Position: refs/heads/master@{#423988}

Powered by Google App Engine
This is Rietveld 408576698