tools/perf/benchmarks/blink_perf.py - Issue 2403513002: Disabling blink_perf.bindings on android reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2403513002: Disabling blink_perf.bindings on android reference (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/blink_perf.py

diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py

index 241aa21a9ae27b3bb205da7147ed691886c04e0b..b95b7c664345017a08a0656fbd3ea0b127e8c893 100644

--- a/tools/perf/benchmarks/blink_perf.py

+++ b/tools/perf/benchmarks/blink_perf.py

@@ -142,7 +142,11 @@ class BlinkPerfBindings(perf_benchmark.PerfBenchmark):

@classmethod

def ShouldDisable(cls, possible_browser):

- return cls.IsSvelte(possible_browser) # http://crbug.com/563979

+ # http://crbug.com/563979

+ return (cls.IsSvelte(possible_browser)

+ # http://crbug.com/653970

+ or (possible_browser.browser_type == 'reference' and

+ possible_browser.platform.GetOSName() == 'android'))

@benchmark.Enabled('content-shell')

« no previous file with comments | « no previous file | no next file » | no next file with comments »