Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 2403503003: Optimize the table creation in the Sys Info page of the feedback app (Closed)
Patch Set: Fix js styles for presubmit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @type {string} 6 * @type {string}
7 * @const 7 * @const
8 */ 8 */
9 var SRT_DOWNLOAD_PAGE = 'https://www.google.com/chrome/cleanup-tool/'; 9 var SRT_DOWNLOAD_PAGE = 'https://www.google.com/chrome/cleanup-tool/';
10 10
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 $('sys-info-url').onclick = function() { 385 $('sys-info-url').onclick = function() {
386 var win = chrome.app.window.get(SYSINFO_WINDOW_ID); 386 var win = chrome.app.window.get(SYSINFO_WINDOW_ID);
387 if (win) { 387 if (win) {
388 win.show(); 388 win.show();
389 return; 389 return;
390 } 390 }
391 chrome.app.window.create( 391 chrome.app.window.create(
392 '/html/sys_info.html', { 392 '/html/sys_info.html', {
393 frame: 'chrome', 393 frame: 'chrome',
394 id: SYSINFO_WINDOW_ID, 394 id: SYSINFO_WINDOW_ID,
395 width: 600, 395 width: 640,
396 height: 400, 396 height: 400,
397 hidden: false, 397 hidden: false,
398 resizable: true 398 resizable: true
399 }, function(appWindow) { 399 }, function(appWindow) {
400 // Define functions for the newly created window. 400 // Define functions for the newly created window.
401 401
402 // Gets the full system information for the new window. 402 // Gets the full system information for the new window.
403 appWindow.contentWindow.getFullSystemInfo = 403 appWindow.contentWindow.getFullSystemInfo =
404 function(callback) { 404 function(callback) {
405 if (isSystemInfoReady) { 405 if (isSystemInfoReady) {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 $('cancel-button').onclick = cancel; 438 $('cancel-button').onclick = cancel;
439 $('remove-attached-file').onclick = clearAttachedFile; 439 $('remove-attached-file').onclick = clearAttachedFile;
440 <if expr="chromeos"> 440 <if expr="chromeos">
441 $('performance-info-checkbox').addEventListener( 441 $('performance-info-checkbox').addEventListener(
442 'change', performanceFeedbackChanged); 442 'change', performanceFeedbackChanged);
443 </if> 443 </if>
444 }); 444 });
445 } 445 }
446 446
447 initialize(); 447 initialize();
OLDNEW
« no previous file with comments | « chrome/browser/resources/feedback/html/sys_info.html ('k') | chrome/browser/resources/feedback/js/sys_info.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698