[inspector] don't use String16 in inspector test runner

test/inspector/inspector-test.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #endif               // !defined(_WIN32) && !defined(_WIN64)
 
 #include "include/libplatform/libplatform.h"
 #include "include/v8.h"
@@ skipping 96 matching lines @@
         InspectorClientImpl::InspectorFromContext(context);
     if (inspector) inspector->willExecuteScript(context, function->ScriptId());
     result = function->Call(context, context->Global(), 0, nullptr);
     if (inspector) inspector->didExecuteScript(context);
   }
 
  private:
   v8::Global<v8::Function> function_;
 };
 
+v8::internal::Vector<uint16_t> ToVector(v8::Local<v8::String> str) {
+  v8::internal::Vector<uint16_t> buffer =
+      v8::internal::Vector<uint16_t>::New(str->Length());
+  str->Write(buffer.start(), 0, str->Length());
+  return buffer;
+}
+
 class SetTimeoutExtension : public v8::Extension {
  public:
   SetTimeoutExtension()
       : v8::Extension("v8_inspector/setTimeout",
                       "native function setTimeout();") {}
 
   virtual v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
       v8::Isolate* isolate, v8::Local<v8::String> name) {
     return v8::FunctionTemplate::New(isolate, SetTimeoutExtension::SetTimeout);
   }
 
  private:
   static void SetTimeout(const v8::FunctionCallbackInfo<v8::Value>& args) {
     if (args.Length() != 2 || !args[1]->IsNumber() ||
         (!args[0]->IsFunction() && !args[0]->IsString()) ||
         args[1].As<v8::Number>()->Value() != 0.0) {
       fprintf(stderr,
               "Internal error: only setTimeout(function, 0) is supported.");
       Exit();
     }
     v8::Local<v8::Context> context = args.GetIsolate()->GetCurrentContext();
     if (args[0]->IsFunction()) {
       TaskRunner::FromContext(context)->Append(new SetTimeoutTask(
           args.GetIsolate(), v8::Local<v8::Function>::Cast(args[0])));
     } else {
-      v8::Local<v8::String> data = args[0].As<v8::String>();
-      std::unique_ptr<uint16_t[]> buffer(new uint16_t[data->Length()]);
-      data->Write(reinterpret_cast<uint16_t*>(buffer.get()), 0, data->Length());
-      v8_inspector::String16 source =
-          v8_inspector::String16(buffer.get(), data->Length());
-      TaskRunner::FromContext(context)->Append(new ExecuteStringTask(source));
+      TaskRunner::FromContext(context)->Append(
+          new ExecuteStringTask(ToVector(args[0].As<v8::String>())));
     }
   }
 };
 
-v8_inspector::String16 ToString16(const v8_inspector::StringView& string) {
+v8::Local<v8::String> ToString(v8::Isolate* isolate,
+                               const v8_inspector::StringView& string) {
   if (string.is8Bit())
-    return v8_inspector::String16(
-        reinterpret_cast<const char*>(string.characters8()), string.length());
-  return v8_inspector::String16(
-      reinterpret_cast<const uint16_t*>(string.characters16()),
-      string.length());
+    return v8::String::NewFromOneByte(isolate, string.characters8(),
+                                      v8::NewStringType::kNormal,
+                                      string.length())
+        .ToLocalChecked();
+  else
+    return v8::String::NewFromTwoByte(isolate, string.characters16(),
+                                      v8::NewStringType::kNormal,
+                                      string.length())
+        .ToLocalChecked();
 }
 
 class FrontendChannelImpl : public InspectorClientImpl::FrontendChannel {
  public:
   explicit FrontendChannelImpl(TaskRunner* frontend_task_runner)
       : frontend_task_runner_(frontend_task_runner) {}
   virtual ~FrontendChannelImpl() {}
 
   void SendMessageToFrontend(const v8_inspector::StringView& message) final {
-    v8_inspector::String16Builder script;
-    script.append("InspectorTest._dispatchMessage(");
-    script.append(ToString16(message));
-    script.append(")");
-    frontend_task_runner_->Append(new ExecuteStringTask(script.toString()));
+    v8::Isolate* isolate = v8::Isolate::GetCurrent();
+    v8::HandleScope scope(v8::Isolate::GetCurrent());
+
+    v8::Local<v8::String> prefix =
+        v8::String::NewFromUtf8(isolate, "InspectorTest._dispatchMessage(",
+                                v8::NewStringType::kInternalized)
+            .ToLocalChecked();
+    v8::Local<v8::String> message_string = ToString(isolate, message);
+    v8::Local<v8::String> suffix =
+        v8::String::NewFromUtf8(isolate, ")", v8::NewStringType::kInternalized)
+            .ToLocalChecked();
+
+    v8::Local<v8::String> result = v8::String::Concat(prefix, message_string);
+    result = v8::String::Concat(result, suffix);
+
+    frontend_task_runner_->Append(new ExecuteStringTask(ToVector(result)));
   }
 
  private:
   TaskRunner* frontend_task_runner_;
 };
 
 }  //  namespace
 
 int main(int argc, char* argv[]) {
   v8::V8::InitializeICUDefaultLocation(argv[0]);
@@ skipping 35 matching lines @@
     if (argv[i][0] == '-') break;
 
     bool exists = false;
     v8::internal::Vector<const char> chars =
         v8::internal::ReadFile(argv[i], &exists, true);
     if (!exists) {
       fprintf(stderr, "Internal error: script file doesn't exists: %s\n",
               argv[i]);
       Exit();
     }
-    v8_inspector::String16 source =
-        v8_inspector::String16::fromUTF8(chars.start(), chars.length());
-    frontend_runner.Append(new ExecuteStringTask(source));
+    frontend_runner.Append(new ExecuteStringTask(chars));
   }
 
   frontend_runner.Join();
   return 0;
 }