Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: scripts/slave/recipe_modules/filter/api.py

Issue 2403473002: filter: temporarily disable analyze_report (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/filter/api.py
diff --git a/scripts/slave/recipe_modules/filter/api.py b/scripts/slave/recipe_modules/filter/api.py
index 75cb1987fd81051c6c3e01e80740e04848c9a243..83cae8df9399191112c7e9524e5633c53a876980 100644
--- a/scripts/slave/recipe_modules/filter/api.py
+++ b/scripts/slave/recipe_modules/filter/api.py
@@ -291,24 +291,5 @@ class FilterApi(recipe_api.RecipeApi):
return self.test_targets, compile_targets
def _report_analyze_result(self, analyze_input, analyze_output):
- try:
- self.m.python(
- 'analyze report',
- self.package_repo_resource('scripts', 'tools', 'runit.py'),
- [
- '--show-path',
- 'python',
- self.package_repo_resource(
- 'scripts', 'slave', 'send_analyze_event.py'),
- # TODO(phajdan.jr): switch to prod.
- '--event-mon-run-type', 'test',
- '--master-name', self.m.properties.get('mastername', ''),
- '--builder-name', self.m.properties.get('buildername', ''),
- '--build-id', self.m.properties.get('buildnumber', ''),
- '--analyze-input', self.m.json.input(analyze_input),
- '--analyze-output', self.m.json.input(analyze_output),
- ],
- )
- except self.m.step.StepFailure: # pragma: no cover
- # TODO(phajdan.jr): make report failures fatal.
- pass
+ # TODO(phajdan.jr): send data to event_mon.
+ return
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698