Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2403453002: Revert of [turbofan] Discard the shared code entry in the optimized code map. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com, Michael Hablich, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Discard the shared code entry in the optimized code map. (patchset #3 id:40001 of https://codereview.chromium.org/2401653002/ ) Reason for revert: Possible GCSTRESS failure, investigating. Original issue's description: > [turbofan] Discard the shared code entry in the optimized code map. > > At one time, we hoped to generate the same code for different > native contexts. But in truth, much performance comes from optimizing > on the native context. Now we abandon this pathway. > > BUG= > > Committed: https://crrev.com/55af3c44c99a6e4cd6d53df775023d760ad2b2c3 > Cr-Commit-Position: refs/heads/master@{#40079} TBR=mstarzinger@chromium.org,ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c59d2f09ec487b4a19fa155dc4d222dde15e8b0f Cr-Commit-Position: refs/heads/master@{#40081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -28 lines) Patch
M src/builtins/arm/builtins-arm.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 3 chunks +17 lines, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 3 chunks +17 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +8 lines, -3 lines 0 comments Download
M src/objects.cc View 8 chunks +61 lines, -13 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mvstanton
Created Revert of [turbofan] Discard the shared code entry in the optimized code map.
4 years, 2 months ago (2016-10-07 12:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403453002/1
4 years, 2 months ago (2016-10-07 12:07:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:08:04 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:08:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c59d2f09ec487b4a19fa155dc4d222dde15e8b0f
Cr-Commit-Position: refs/heads/master@{#40081}

Powered by Google App Engine
This is Rietveld 408576698