Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2403443002: Remove MoveSelectionCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, chongz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MoveSelectionCommand MoveSelectionCommand is no longer in use after r422915. Hence, this patch removes it from the code base. BUG=n/a Committed: https://crrev.com/c465442579b6c97c3ef76f4169fbcfedc01f75c7 Cr-Commit-Position: refs/heads/master@{#423843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -178 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-07 09:50:30 UTC) #4
yosin_UTC9
lgtm Thanks for doing this!
4 years, 2 months ago (2016-10-07 09:56:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403443002/1
4 years, 2 months ago (2016-10-07 10:39:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 13:06:03 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 13:08:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c465442579b6c97c3ef76f4169fbcfedc01f75c7
Cr-Commit-Position: refs/heads/master@{#423843}

Powered by Google App Engine
This is Rietveld 408576698