Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2403433002: Remove ScopedVector from PasswordSyncableService. (Closed)

Created:
4 years, 2 months ago by vasilii
Modified:
4 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from PasswordSyncableService. BUG=555132 Committed: https://crrev.com/f0f76b020bf69084132833f8ac86a5f45bbde9e9 Cr-Commit-Position: refs/heads/master@{#423835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M components/password_manager/core/browser/password_syncable_service.h View 4 chunks +5 lines, -8 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service.cc View 12 chunks +34 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
vasilii
Hi Vaclav, please review.
4 years, 2 months ago (2016-10-07 09:13:13 UTC) #4
vabr (Chromium)
LGTM, thanks! Vaclav
4 years, 2 months ago (2016-10-07 10:38:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403433002/1
4 years, 2 months ago (2016-10-07 11:29:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 11:34:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 11:37:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0f76b020bf69084132833f8ac86a5f45bbde9e9
Cr-Commit-Position: refs/heads/master@{#423835}

Powered by Google App Engine
This is Rietveld 408576698