LayoutTests/fast/events/scroll-event-handler-reused-window.html - Issue 240343002: Track event handlers on windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/scroll-event-handler-reused-window.html

Issue 240343002: Track event handlers on windows (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed assertions not to go through the document. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Rick Byers 2014/05/06 20:54:39 missing expected output for this test missing expected output for this test Sami 2014/05/07 10:36:41 Oops, added. Show quoted text On 2014/05/06 20:54:39, Rick Byers wrote: > missing expected output for this test Oops, added.
	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description('Test tracking event handlers with a reused DOMWindow.');
	Rick Byers 2014/05/06 20:54:39 can you elaborate on what you mean by "reused DOMW can you elaborate on what you mean by "reused DOMWindow" here? Sami 2014/05/07 10:36:41 Sure, I've added a comment here: // \|window.open\| Show quoted text On 2014/05/06 20:54:39, Rick Byers wrote: > can you elaborate on what you mean by "reused DOMWindow" here? Sure, I've added a comment here: // \|window.open\| returns a DOMWindow synchronously without waiting for the // network load to finish. Once the load completes, we transition the existing // window object to the document instead of creating a new one like we normally // would. The purpose of this test is to ensure event handlers added on the // window are still present after the window is reused with the new document. // See DocumentLoader.cpp for details. Rick Byers 2014/05/07 13:28:21 Fascinating, thanks! Show quoted text On 2014/05/07 10:36:41, Sami wrote: > On 2014/05/06 20:54:39, Rick Byers wrote: > > can you elaborate on what you mean by "reused DOMWindow" here? > > Sure, I've added a comment here: > > // \|window.open\| returns a DOMWindow synchronously without waiting for the > // network load to finish. Once the load completes, we transition the existing > // window object to the document instead of creating a new one like we normally > // would. The purpose of this test is to ensure event handlers added on the > // window are still present after the window is reused with the new document. > // See DocumentLoader.cpp for details. Fascinating, thanks!
	5

	6 if (window.testRunner) {

	7 testRunner.setCanOpenWindows();

	8 testRunner.waitUntilDone();

	9 }

	10

	11 var newWindow = window.open('resources/conclude-test-in-parent.html');

	12 newWindow.onscroll = function() {};

	13

	14 function concludeTest() {

	15 shouldBe('window.internals.scrollEventHandlerCount(newWindow.document)', '1' );

	16 testRunner.notifyDone();

	17 }

	18 </script>

	19 </body>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/events/scroll-event-handler-count-expected.txt ('k') | Source/core/frame/DOMWindow.cpp » ('j') | Source/core/frame/DOMWindow.cpp » ('J')