Expose Physical Web metadata to native clients over JNI

chrome/browser/android/physical_web/physical_web_data_source_android.h

Index: chrome/browser/android/physical_web/physical_web_data_source_android.h
diff --git a/chrome/browser/android/physical_web/physical_web_data_source_android.h b/chrome/browser/android/physical_web/physical_web_data_source_android.h
index 8454c857cf6793ca638e0aeb1b4b01a81207e498..b76458b8dc0651718dfc1226b139a5741a219f6b 100644
--- a/chrome/browser/android/physical_web/physical_web_data_source_android.h
+++ b/chrome/browser/android/physical_web/physical_web_data_source_android.h
@@ -15,6 +15,33 @@ namespace base {
 class ListValue;
 }
 
+// A container for Physical Web metadata. This is primarily a wrapper for a
+// ListValue so we can append to it over JNI.

[gone, 2016/10/24 16:35:35]

Is it worth yanking this out into its own file?

[mattreynolds, 2016/10/24 22:39:52]

I tried this, but ran into issues with the way the UrlManager_jni.h include is
auto-generated.

+class PhysicalWebCollection {
+ public:
+  PhysicalWebCollection();
+  ~PhysicalWebCollection();
+
+  void AppendMetadataItem(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj,
+      const base::android::JavaParamRef<jstring>& j_request_url,
+      jdouble distance_estimate,
+      jint scan_timestamp,
+      const base::android::JavaParamRef<jstring>& j_site_url,
+      const base::android::JavaParamRef<jstring>& j_icon_url,
+      const base::android::JavaParamRef<jstring>& j_title,
+      const base::android::JavaParamRef<jstring>& j_description,
+      const base::android::JavaParamRef<jstring>& j_group_id);
+
+  std::unique_ptr<base::ListValue> GetMetadataList();

[gone, 2016/10/24 16:35:35]

Is it worth putting a note here that this hands over the unique list and
shouldn't be called twice?  Maybe a DCHECK in the function body itself?

[mattreynolds, 2016/10/24 22:39:52]

Done.

+
+ private:
+  std::unique_ptr<base::ListValue> metadata_list_;
+
+  DISALLOW_COPY_AND_ASSIGN(PhysicalWebCollection);
+};
+
 class PhysicalWebDataSourceAndroid : public PhysicalWebDataSourceImpl {
  public:
   PhysicalWebDataSourceAndroid();