third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h - Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: Use StyleValueFactory & ComputedStyleCSSValueMapping for unsupported Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

index 97597e29e448352e9eb092287dc039ec0ef7939f..e42f646661998c0d2433069731aa0aacc4178d34 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

@@ -55,6 +55,8 @@ class CORE_EXPORT CSSCalcLength final : public CSSLengthValue {

static CSSCalcLength* create(const CSSLengthValue*);

static CSSCalcLength* fromCSSValue(const CSSPrimitiveValue&);

+ static CSSCalcLength* fromLength(const Length&);

#define GETTER_MACRO(name, type) \

double name(bool& isNull) { \

isNull = !m_unitData.has(type); \