[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp

Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
index bf81ceb3b4fb65928766c63e5b4ca791cd08414a..c6c9797b598f5e80f38f6e1dc23e54320aab4850 100644
--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMapTest.cpp
@@ -23,6 +23,7 @@ class FilteredComputedStylePropertyMapTest : public ::testing::Test {
   CSSComputedStyleDeclaration* declaration() const {
     return m_declaration.get();
   }
+  Node* pageNode() { return m_page->document().documentElement(); }

[sashab, 2017/01/09 02:19:04]

Node* pageNode() const { ... }

Can this be const Node&?
At the very least - const Node*

 
  private:
   std::unique_ptr<DummyPageHolder> m_page;
@@ -38,19 +39,19 @@ TEST_F(FilteredComputedStylePropertyMapTest, GetProperties) {
 
   FilteredComputedStylePropertyMap* map =
       FilteredComputedStylePropertyMap::create(declaration(), nativeProperties,
-                                               customProperties);
+                                               customProperties, pageNode());
   EXPECT_TRUE(map->getProperties().contains("color"));
   EXPECT_TRUE(map->getProperties().contains("align-items"));
   EXPECT_TRUE(map->getProperties().contains("--foo"));
   EXPECT_TRUE(map->getProperties().contains("--bar"));
 
   map = FilteredComputedStylePropertyMap::create(
-      declaration(), nativeProperties, emptyCustomProperties);
+      declaration(), nativeProperties, emptyCustomProperties, pageNode());
   EXPECT_TRUE(map->getProperties().contains("color"));
   EXPECT_TRUE(map->getProperties().contains("align-items"));
 
   map = FilteredComputedStylePropertyMap::create(
-      declaration(), emptyNativeProperties, customProperties);
+      declaration(), emptyNativeProperties, customProperties, pageNode());
   EXPECT_TRUE(map->getProperties().contains("--foo"));
   EXPECT_TRUE(map->getProperties().contains("--bar"));
 }
@@ -60,8 +61,8 @@ TEST_F(FilteredComputedStylePropertyMapTest, NativePropertyAccessors) {
       {CSSPropertyColor, CSSPropertyAlignItems});
   Vector<AtomicString> emptyCustomProperties;
   FilteredComputedStylePropertyMap* map =
-      FilteredComputedStylePropertyMap::create(declaration(), nativeProperties,
-                                               emptyCustomProperties);
+      FilteredComputedStylePropertyMap::create(
+          declaration(), nativeProperties, emptyCustomProperties, pageNode());
 
   DummyExceptionStateForTesting exceptionState;
 
@@ -92,7 +93,7 @@ TEST_F(FilteredComputedStylePropertyMapTest, CustomPropertyAccessors) {
   Vector<AtomicString> customProperties({"--foo", "--bar"});
   FilteredComputedStylePropertyMap* map =
       FilteredComputedStylePropertyMap::create(
-          declaration(), emptyNativeProperties, customProperties);
+          declaration(), emptyNativeProperties, customProperties, pageNode());
 
   DummyExceptionStateForTesting exceptionState;