third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h - Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

index edf620f87f2e5b7c6d777eed09af9bb9aee6e2b5..12b56558a02beb3a8f6a21b1107387ad4e16d2b1 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h

@@ -19,6 +19,7 @@ class CORE_EXPORT CSSKeywordValue final : public CSSStyleValue {

DEFINE_WRAPPERTYPEINFO();

public:

+ static CSSKeywordValue* create(const AtomicString& keyword);

static CSSKeywordValue* create(const AtomicString& keyword, ExceptionState&);

sashab 2017/01/09 02:19:04 Can you use a default value for ExceptionState?

StyleValueType type() const override { return KeywordType; }