third_party/WebKit/Source/core/dom/Element.cpp - Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2403423002: [CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)

Patch Set: remove unnecessary change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index fd79b779eabf4799b7ba977e3148225b61db4544..8a4878e50c021a0877e57f0734025cdd5e5c94fd 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1905,6 +1905,8 @@ PassRefPtr<ComputedStyle> Element::propagateInheritedProperties(

return nullptr;

if (hasAnimations())

return nullptr;

+ if (isPseudoElement())

meade_UTC10 2016/12/08 23:22:15 What's this for? Could you please add why you need

+ return nullptr;

const ComputedStyle* parentStyle = parentComputedStyle();

DCHECK(parentStyle);

const ComputedStyle* style = computedStyle();