Chromium Code Reviews Chromium Code Reviews
Issue 2403423002:
[CSSTypedOM] Computed StylePropertyMap use ComputedStyle for Lengths (Closed)
| Index: third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html |
| diff --git a/third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html b/third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html |
| index 600cfa99562b7292df3d16531f13d07a3a7df88c..bed7a6126374816b68efa9fbf8d5ae8c882f758f 100644 |
| --- a/third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html |
| +++ b/third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html |
| @@ -1,35 +1,53 @@ |
| -<!DOCTYPE html> |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| <script src='../../resources/testharness.js'></script> |
| <script src='../../resources/testharnessreport.js'></script> |
| - |
| <style> |
| #testElement { |
| border: 5px solid purple; |
| + width: 120px; |
| + background-color: green; |
| } |
| - |
| -#testElement:after { |
| - border: 1px solid black; |
| +#testElement::after { |
| + content: 'after'; |
| + position: absolute; |
| + border: 1px solid black; |
| + width: 100px; |
| + top: 10px; |
| + background-color: red; |
| } |
| </style> |
| - |
| -<div id="testElement"></div> |
| - |
| +</head> |
| +<body> |
| +<p id='testElement'>test element</p> |
| <script> |
| - |
| -var computedStyleMap = getComputedStyleMap(testElement); |
| -var pseudoComputedStyleMap = getComputedStyleMap(testElement, '::after'); |
| -test(function() { |
| - assert_equals(computedStyleMap.get('border-top-width').cssText, '5px'); |
| - assert_equals(pseudoComputedStyleMap.get('border-top-width').cssText, '1px'); |
| -}, 'get on Computed StyleMap of pseudo element returns correct styles'); |
| - |
| -test(function() { |
| - // TODO(meade): When actual multiple valued properties are supported, use one of them. |
| - |
| - var styleValueList = pseudoComputedStyleMap.getAll('border-top-width'); |
| - assert_equals(styleValueList.length, 1); |
| - assert_equals(styleValueList[0].cssText, '1px'); |
| -}, 'getAll on Computed StyleMap of pseudo element returns list of correct styles'); |
| - |
| +var computedStyleMap; |
| +var pseudoComputedStyleMap |
| + |
| +var t1 = async_test('get on Computed StyleMap of pseudo element returns correct styles'); |
| +var t2 = async_test('getAll on Computed StyleMap of pseudo element returns list of correct styles'); |
| + |
| +document.onreadystatechange = function() { |
| + if(document.readyState == 'complete') { |
| + t1.step(function() { |
| + pseudoComputedStyleMap = getComputedStyleMap(testElement, '::after'); |
|
meade_UTC10
2016/12/08 23:22:15
Would it still work to put this statement outside
|
| + var pseudoResult = pseudoComputedStyleMap.get('width'); |
| + assert_true(pseudoResult instanceof CSSSimpleLength); |
| + assert_equals(pseudoResult.cssText, '100px'); |
| + }); |
| + t1.done(); |
| + |
| + t2.step(function() { |
| + pseudoComputedStyleMap = getComputedStyleMap(testElement, '::after'); |
| + var styleValueList = pseudoComputedStyleMap.getAll('width'); |
| + assert_equals(styleValueList.length, 1); |
| + assert_equals(styleValueList[0].cssText, '100px'); |
| + }); |
| + t2.done(); |
| + } |
| +}; |
| </script> |
| +</body> |
| +</html> |
